LTE-3039: IDM is stuck in XLE causing XB to not discover Remote Device - #15
Open
biju-vi wants to merge 2 commits into
Open
LTE-3039: IDM is stuck in XLE causing XB to not discover Remote Device#15biju-vi wants to merge 2 commits into
biju-vi wants to merge 2 commits into
Conversation
Reason for change: Exit from loop if socket is not usable Test Procedure: NA Risks: Low Signed-off-by: biju.vijayanindiradevi@sky.uk
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the message receive/processing loops to exit early when a data encryption step fails, preventing continued processing after an error.
Changes:
- Add
break;after “Data encryption failed” error logging inIDM_Incoming_FT_Response. - Add
break;after “Data encryption failed” error logging inIDM_SFT_receive. - Add inline comments explaining the early-exit behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+519
to
+521
| CcspTraceError(("(%s:%d) Data encryption failed (Err: %d)\n", __FUNCTION__, __LINE__,bytes)); | ||
| // Exit from loop if socket is not usable ot there is no data to read | ||
| break; |
Reason for change: Exit from loop if socket is not usable Test Procedure: NA Risks: Low Signed-off-by: biju.vijayanindiradevi@sky.uk
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
source/InterDeviceManager/Idm_msg_process.c:882
- Similar to the earlier receive loop: breaking on bytes<=0 prevents a hang, but the function still returns FT_SUCCESS unconditionally. That can report success even when fewer than total_bytes were received. Return FT_ERROR when length < total_bytes after the loop (and optionally clean up the partial file).
CcspTraceError(("(%s:%d) Socket Read Error (bytes read: %d)\n", __FUNCTION__, __LINE__,bytes));
// Exit from loop if socket is not usable or no data to read
break;
Comment on lines
+519
to
+521
| CcspTraceError(("(%s:%d) Socket Read Error (bytes read: %d)\n", __FUNCTION__, __LINE__,bytes)); | ||
| // Exit from loop if socket is not usable or there is no data to read | ||
| break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Exit from loop if socket is not usable
Test Procedure: NA
Risks: Low
Signed-off-by: biju.vijayanindiradevi@sky.uk